Re: [PATCH net-next v2] tcp: md5: check md5 signature without socket lock

From: Dmitry Popov
Date: Wed Aug 06 2014 - 18:33:57 EST


On Wed, 06 Aug 2014 14:52:18 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Dmitry Popov <ixaphire@xxxxxxxxxx>
> Date: Thu, 7 Aug 2014 01:49:53 +0400
>
> > Since a8afca032 (tcp: md5: protects md5sig_info with RCU) tcp_md5_do_lookup
> > doesn't require socket lock, rcu_read_lock is enough. Therefore socket lock is
> > no longer required for tcp_v{4,6}_inbound_md5_hash too, so we can move these
> > calls (wrapped with rcu_read_{,un}lock) before bh_lock_sock:
> > from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
> >
> > Signed-off-by: Dmitry Popov <ixaphire@xxxxxxxxxx>
>
> Please respin this against the current 'net' tree, it doesn't apply.

Oops, my bad, sorry. I will resubmit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/