Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs

From: Jason Gunthorpe
Date: Wed Aug 06 2014 - 12:30:33 EST


On Wed, Aug 06, 2014 at 11:18:20AM -0400, Murali Karicheri wrote:
> Keystone PCI controller has a limitation that memory read request
> size must not exceed 256 bytes. This is a hardware limitation and
> add a quirk to force this limit on all downstream devices by
> updating mrrs.

Does this still work if the tuning is enabled, or does the tuning run
after this?

> + if (pcie_get_readrq(dev) > 256) {
> + pr_info("limiting mrrs to 256\n");
> + pcie_set_readrq(dev, 256);

The pr_info should either go away, or at least print the PCI bdf..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/