Re: [RFC PATCH 0/3] ftrace: Add a ftrace test collection

From: Steven Rostedt
Date: Tue Aug 05 2014 - 17:38:10 EST


Hi Masami,

This looks great. I'm a bit busy at the moment (just came back from
vacation, and digging myself out of the hole that left me). But I
definitely want this in. I have a bunch of tests too, that I can put on
top of this. My tests are rather hacky, and hard code a lot of stuff in
them, but they do test a bunch of features of ftrace. It shouldn't be
too hard to include them here.


On Tue, 05 Aug 2014 02:45:44 +0000
Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:

> Hi,
>
> I'd like to introduce a collection of testcases for ftrace to
> avoid regressions.
>
> For a long time, we've tried to stabilize and extend ftrace
> tracing infrastructure. This small test framework is a kind of
> stabilizing work for ftrace. For the first step, this series
> just introduces a few basic testcases. However, it is easy to
> add additional tests. I'd like to ask you, ftrace developers,
> to add tests for your features to ensure it will not be broken
> by future works.
>
> ftracetest is a tiny bash script so that anyone can easily
> understand what it does. I think it is better to share and
> discuss this tests before growing it.
>
> - Is it enough to support bash script? (of course you can
> invoke other commands from the script)
> - What's the good naming method of testcases?
> - Is any dependency check required?
>
> BTW, I decided to put this under tools/testing/ftrace instead
> of tools/testing/selftests/, because all tests requires root
> privilege. It will be one of discussion points. Anyway,
> it is easy to integrate this to the selftests.

I agree. I think having its own directory is a good idea. Lets see what
other people think. When I get time, I'll see if I can start a branch
that pulls this in and start adding my own tests on top of it.

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/