Re: [PATCH 2/2 v6] locking/selftest: Support queued rwlock

From: Shuah Khan
Date: Tue Aug 05 2014 - 11:05:58 EST


On Tue, Aug 5, 2014 at 8:54 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Aug 05, 2014 at 04:44:34PM +0200, Maarten Lankhorst wrote:
>> op 05-08-14 16:41, Peter Zijlstra schreef:
>
>> >> A bit off topic for this patch, however relevant for tests in general.
>> >> Is there a reason why these locking selftests need to be under lib?
>> >> Can they be consolidated under tools/testing/selftests?
>> > tools/ seems wrong as its very much not userspace.
>> Could be moved to kernel/locking though now that all other locking moved there. :-)
>
> Yes, I suppose we could do that; IIRC the reason I left it where it is
> is because there are more tests in lib/.

Maybe if tools doesn't sounds right, we could move testing from under tools
and have it be testing

We have several selftests spread around in the kernel tree. It makes it easier
to pull them under a single make target devtest. I sent in a patch add devtest
target that runs tests that are under tools/testing/selftests a couple of
weeks ago, hopefully it will be included in 3.17. I am working towards pulling
more kernel selftests that exist under this devtest umbrella. That is
the motivation
behind starting this conversation. :)

-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/