Re: [PATCH] netdev: octeon_mgmt: Use devm_ioremap_resource

From: David Miller
Date: Mon Aug 04 2014 - 15:38:59 EST


From: Himangi Saraogi <himangi774@xxxxxxxxx>
Date: Thu, 31 Jul 2014 12:36:53 +0530

> This patch introduces the use of devm_ioremap_resource instead of
> devm_request_mem_region and devm_ioremap. The error handling on the
> platform_get_resource is done way with. The size and start fields in the
> octeon_mgmt are no longer needed. So they are removed and there
> initialization skipped. Also, error handling is added on the values
> returned by devm_ioremap_resource.
>
> Signed-off-by: Himangi Saraogi <himangi774@xxxxxxxxx>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> ---
> Not compile tested.

David Daney provided you with a mechanism by which you could
compile test this change, and then I see no response at all
from you after that.

I'm not applying this until it is at least compile tested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/