Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region

From: joeyli
Date: Mon Aug 04 2014 - 10:56:57 EST


Hi Pavel,

Thanks for your review!

On Mon, Aug 04, 2014 at 03:08:11PM +0200, Pavel Machek wrote:
> > > +
> > > + list_for_each_entry(region, &nosave_regions, list) {
> > > + if (pfn >= region->start_pfn && pfn < region->end_pfn) {
> > > + pr_err("PM: %#010llx in e820 nosave regsion: "
>
> And while looking at it, this should probably be spelled "region".
>
> ...plus maybe past part of changelog here into the comment?
>

Oh, sorry for my typo! I will correct it and comment in next version.

> Otherwise looks good to me,
>
> Acked-by: Pavel Machek <pavel@xxxxxx>
> Pavel

Regards
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/