Re: [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*phspecifiertodump memory

[micky]

On 08/02/2014 01:55 AM, Fabio Falzoi wrote:
> On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
> > Documentation/printk-formats.txt
> >
> > Raw buffer as a hex string:
> > 	%*ph	00 01 02  ...  3f
> > 	%*phC	00:01:02: ... :3f
> > 	%*phD	00-01-02- ... -3f
> > 	%*phN	000102 ... 3f
> >
> > 	For printing a small buffers (up to 64 bytes long) as a hex string with
> > 	certain separator. For the larger buffers consider to use
> > 	print_hex_dump().
> >
> >
> > Since we can't make sure the cnt value, it is not good use "%*ph",
> > because it must make cnt <= 64.
> > dw_len * 4  <= 64 ?
> Hi Micky,
>
> I think that in these two cases we can rely on print_hex_dump_bytes that
> doesn't have the dev_dbg limit on buffer size.
> Let me know what you think about it. If you agree, I can send a new version
> for patches 3/4 and 4/4, since the first two have already been merged in the
> linux-next tree by Greg.
Hi Fabio,

I think it is good, Thanks.

Best Regards,
micky
> Regards,
> Fabio
> .

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/