Re: [PATCH] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

From: Jiri Olsa
Date: Sun Aug 03 2014 - 08:14:51 EST


On Sat, Aug 02, 2014 at 08:13:22PM +0200, Yann Droneaud wrote:
> In case of failure, unrelated to PERF_FLAG_FD_CLOEXEC,
> perf_flag_probe() reports the error twice. For example:
>
> $ perf record ls
> Error:
> perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error 16 (Device or resource busy)
> perf_event_open(..., 0) failed unexpectedly with error 16 (Device or resource busy)

seems ok,
but since your patch is not based on my other patch,
please provide the changelog perf out without it

---
> The PMU counters are busy/taken by another profiler.
> We found oprofile daemon running, please stop it and try again.
---

also, please provide both before and after outputs
I'll queue it up with those other 2 patches

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/