Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP

From: Ingo Molnar
Date: Sat Aug 02 2014 - 01:27:47 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > > I yelled at BIOS engineers over their PMU usage and $vendor
> > > added a BIOS knob to disable that, I'll yell at BIOS engineers
> > > again, just give me their number.
> > >
> > > Really, say NO already.
> >
> > Ok, so no technical reason, merely a "me vs you" power play.

Andi, stop the silly arguments already and stop launching personal
attacks against maintainers who are simply doing their job!

> Clearly you forgot the discussion we had back then, you want me to
> find you a link or do you think you can Google it yourself? I'm not
> the only one who thinks its a terrible idea for the BIOS to involve
> itself in these things.

The BIOS has no business stealing or meddling with limited resources
used by and managed by the kernel, such as PMU state. In addition to
the loss of utility to users when the BIOS interferes, PMUs are buggy
and fragile enough even without any undue BIOS interference.

This was escallated up to Linus last time around and he agreed that
such BIOS meddling with kernel state is not acceptable, so you'll
probably have to convince him as well in addition to having to
convince every perf and x86 maintainer.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/