Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec

[Sergei Shtylyov]

Hello.

On 01-08-2014 9:22, Peter Ujfalusi wrote:

> > > The board uses aic3106 for audio.

> > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> > > ---
> > >    arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
> > >    1 file changed, 14 insertions(+)

> > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> > > index 09118c72e83f..b9ef2be0b145 100644
> > > --- a/arch/arm/boot/dts/da850-evm.dts
> > > +++ b/arch/arm/boot/dts/da850-evm.dts
> > > @@ -51,6 +51,20 @@
> > >                tps: tps@48 {
> > >                    reg = <0x48>;
> > >                };
> > > +            tlv320aic3106: tlv320aic3106@1b {

[...]

> > Also, the ePAPR standard [1] says:

> > The name of a node should be somewhat generic, reflecting the function of the
> > device and not its precise programming model.

> True. This is why the node for the audio support is named as 'sound'. For the
> components, like in this case I do not see issue to call the audio codec with
> it's name.

   I do. We should follow the standard consistently. Why not call the node 
"sound-codec"?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/