Re: [PATCH libata/for-3.16-fixes] libata: introduce ata_host->n_tags to avoid oops on SAS controllers

From: Tejun Heo
Date: Wed Jul 23 2014 - 12:36:12 EST


Hello,

On Wed, Jul 23, 2014 at 06:31:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hmmm, wasn't ATA_MAX_QUEUE used before not ATA_MAX_QUEUE - 1?
>
> It seems that after your patch the loop in the ata_qc_new() will use
> only 30 tags and not 31 ones?

It was always 31 (ATA_MAX_QUEUE - 1) with the tag 31 reserved for EH
commands. The previous patch just used limit value which is one too
high. I'm planning to change that but this is the way it has always
been.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/