Re: [PATCH 4/4] drivers/pinctrl/qcom/pinctrl-msm.c: drop negativity check on unsigned value

From: Linus Walleij
Date: Wed Jul 23 2014 - 09:25:40 EST


On Thu, Jul 17, 2014 at 6:29 PM, Andrey Utkin
<andrey.krieger.utkin@xxxxxxxxx> wrote:

> [linux-3.16-rc5/drivers/pinctrl/pinctrl-msm.c:145]: (style) Checking if
> unsigned variable 'mux_bit' is less than zero.
>
> if (WARN_ON(g->mux_bit < 0))
> return -EINVAL;
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80491
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>

Patch applied after fixing $SUBJECT, BjÃrn protest if you don't like
it...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/