Re: [PATCH] workqueue: get the probable node ID from the first CPU of the mask

From: Lai Jiangshan
Date: Tue Jul 22 2014 - 21:25:42 EST


On 07/22/2014 11:30 PM, Tejun Heo wrote:
> On Tue, Jul 22, 2014 at 01:04:02PM +0800, Lai Jiangshan wrote:
>> + node = cpu_to_node(cpumask_first(pool->attrs->cpumask));
>
> Minor but maybe cpumask_any() is a better fit here?
>

It is OK, the result are the same. But I still think cpumask_first() is better since
its name sounds deterministic while we need a deterministic value for pool->node.

Thanks,
Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/