Re: [PATCH] pinctrl: qcom: Make muxing of gpio function explicit

[Linus Walleij]

On Sat, Jul 12, 2014 at 3:21 AM, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx> wrote:

> Instead of relying on pinmux->disable(), make the gpio function an
> explicit function for all pins that supports it.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>

Thanks, patch applied!

> This fixes the regression that was introduced by removing the disable function
> from the pinmux ops. I was exploiting the disable function to put the gpio pins
> "back" into gpio state and this was apparently not the right way to do things.

This is so much cleaner I think.

Please proceed to patch your DTS files for this as needed.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/