Re: [PATCH] arch: x86: boot: bioscall.S: simplify self-modification of the INT instruction

[H. Peter Anvin]

On 07/22/2014 04:01 AM, Klemen Jan Enova wrote:
> At the start of the intcall function, the %al register is compared to
> 0x3f. If it does not equal 0x3f it is equated to it. Instruction flow
> continues in both cases from the label 1. The comparison is therefore
> unneeded.
> 
> Testing data is appended.
> 
> Signed-off-and-tested-by: Klemen Jan Enova <klemen.jan.enova@xxxxxxxxx>

NAK.

This is a performance optimization - the SMC takes a substantial penalty
so the write is avoided if necessary.

Also, 3f is a label, not 0x3f.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/