Re: [PATCH] x86, TSC: Add a software TSC offset

From: Borislav Petkov
Date: Mon Jul 21 2014 - 17:52:36 EST


On Mon, Jul 21, 2014 at 02:41:50PM -0700, Andy Lutomirski wrote:
> How will this be compatible with the vdso?

I've never thought about it yet. How compatible would you want it to be
and what do you expect from it?

Remember, this is only attempting to be a hardware workaround for a
smallish number of systems out there. Most of current machines should
have stable and synched TSCs.

> Also, IIRC, rdtscp does not need rdtsc_barrier(), whereas rdtsc does.
> Getting this wrong will be a significant slowdown.

This is too cryptic for me - get_cycles doesn't barrier around the TSC
now either. Again, we will most likely end up not using RDTSCP anyway.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/