Re: [PATCHv3 00/19] perf tools: Factor ordered samples queue

From: Adrian Hunter
Date: Mon Jul 21 2014 - 09:00:15 EST


On 07/21/2014 03:35 PM, Jiri Olsa wrote:
> On Mon, Jul 21, 2014 at 03:09:07PM +0300, Adrian Hunter wrote:
>
> SNIP
>
>>>>
>>>> ...so is the 100MB limit needed at all if you have ROUND
>>>> events?
>>>
>>> for data files captured without the ROUND events fix
>>
>> I am not sure it should be the default then, if it is
>> not needed going forward.
>
> I'd be ok with not setting 100MB limit by default, just need a way
> to configure it.. so without following patch:
> perf tools: Limit the ordered events queue by default to 100MB

Ok then. Also it would be good to have a warning if a premature flush
is forced, so that you can distinguish the cause of out-of-order
messages.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/