Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

[David Miller]

From: Ethan Zhao <ethan.zhao@xxxxxxxxxx>
Date: Fri, 18 Jul 2014 11:43:29 +0800

> netxen driver has implemented netxen_nic_get_ethtool_stats() interface,
> but it doesn't collect stats.rxdropped in driver, so we will get
> different rx_dropped statistic information while using ifconfig and ethtool.
> this patch fills stats.rxdropped field with data from net core
> with dev_get_stats() just as ixgbe driver did for some of its stats.
> 
> Tested with last netxen 4.0.82
> Compiled with stable 3.15.6
> 
> Signed-off-by: Ethan Zhao <ethan.zhao@xxxxxxxxxx>
> Tested-by: Sriharsha Yadagudde <sriharsha.devdas@xxxxxxxxxx>

ethtool stats are _NOT_ the place to duplicate normal netdev stats,
PERIOD.

The only exception is when you maintainer per-queue instaces of these
stats, and want to export that information to the user.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/