RE: [char-misc-next 4/5] mei: nfc: clean nfc internal struct on host exit

From: Winkler, Tomas
Date: Sun Jul 20 2014 - 02:31:11 EST


> > @@ -553,6 +553,7 @@ void mei_nfc_host_exit(struct mei_device *dev)
> > {
> > struct mei_nfc_dev *ndev = &nfc_dev;
> > cancel_work_sync(&ndev->init_work);
> > + memset(ndev, 0, sizeof(struct mei_nfc_dev));
>
> This implies that something is using a "static" device structure, which
> isn't allowed by the driver core. So please fix the root cause here,
> don't paper over the bug.
>
You are partially correct as this is not the 'struct device' it just a nfc singleton in any case it is not really nice
and we have the fix in queue but it is rather extensive rework and I guess it won't be suitable for stable
so hence this one liner fix.

Thanks
Tomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/