Re: [PATCH 0/6] PM / Hibernate: Memory bitmap scalability improvements

From: Joerg Roedel
Date: Sat Jul 19 2014 - 03:56:01 EST


Hi Rafael,

On Sat, Jul 19, 2014 at 12:05:02AM +0200, Rafael J. Wysocki wrote:
> On Friday, July 18, 2014 01:57:17 PM Joerg Roedel wrote:
> > here is a patch set to improve the scalability of the memory
> > bitmap implementation used for hibernation. The current
> > implementation does not scale well to machines with several
> > TB of memory. A resume on those machines may cause soft
> > lockups to be reported.
>
> Looks good.
>
> How much testing did that receive?

Well, I did function testing of the radix tree and the old memory bitmap
in parallel (patches 1-4) and looked for the warnings to trigger in case
the bitmaps return different results. With these patches the radix tree
produced always the same results as the old implementation (none of the
warnings did trigger).

I first tested with KVM (64 bit and 32 bit x86 guest) and later on real
amd64 machines. One of our partners tested the patches on a 1TB, a 4TB
and a 12TB memory machine, always with positive result.

Thanks,

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/