Re: [PATCH 1/4] drivers/hsi/controllers/omap_ssi{,_port}.c: fix failure checks

From: Sebastian Reichel
Date: Thu Jul 17 2014 - 16:51:26 EST


Hi,

On Thu, Jul 17, 2014 at 04:53:54PM +0300, Andrey Utkin wrote:
> 1.
>
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if
> unsigned variable 'gdd_irq' is less than zero.
>
> Source code is
>
> omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
> if (omap_ssi->gdd_irq < 0) {
>
> 2.
>
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking
> if unsigned variable 'irq' is less than zero.
>
> Source code is
>
> omap_port->irq = platform_get_irq(pd, 0);
> if (omap_port->irq < 0) {
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80441
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>

applied to my for-next branch:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=b74d4954ae6a6799f7ee832bc377795ab506f4b1

-- Sebastian

Attachment: signature.asc
Description: Digital signature