Re: [PATCH] x86-64, espfix: consider IRQs are off when initializing

From: H. Peter Anvin
Date: Thu Jul 17 2014 - 12:16:32 EST


On 07/17/2014 08:58 AM, Sasha Levin wrote:
>
> This is the result of getting an error message for allocating with GFP_KERNEL
> saying that we can't do that with IRQs off.
>
> My assumption after that was that we're not going to be sleeping at all, which
> is why spinlock/GFP_ATOMIC would be correct here.
>

So we have a problem, but the proposed solution is wrong. This is
messy... we need this code to be successfully executed before we can
safely schedule *user space* on that processor, but there is no
requirement that we execute it before we enable *interrupts* on that
processor, so maybe there is a way we can fulfill those requirements.

The alternative would be to fail to enable the processor or going into a
spin loop, but either of those would been rather toxic to me.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/