Re: [PATCH] checkpatch.pl: Remove --file option

[Borislav Petkov]

On Thu, Jul 17, 2014 at 05:34:28PM +0200, Richard Weinberger wrote:
> checkpatch.pl is a nice tool to find issues in patches.
> Sadly this tool gets more and more  abused by various people to create
> style cleanups for source files within the kernel.
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.
> 
> Suggested-by: NeilBrown <neilb@xxxxxxx>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>

Very good idea:

Acked-by: Borislav Petkov <bp@xxxxxxx>

You could also make it do:

	if ($file) {
		print STDERR "Go find real bugs in the kernel instead!\n";
		exit(-1);
	}

if someone supplies --file on the cmdline.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/