Re: [PATCH v3 1/6] acerhdf: Adding support for "manual mode"

From: Borislav Petkov
Date: Thu Jul 17 2014 - 05:45:35 EST


On Sat, May 03, 2014 at 07:59:21PM +0200, Peter Feuerer wrote:
> Some Acer models require an additional command to turn off the fan after
> bios mode has been enabled. Adding new section in bios table to allow
> support for those models, by writing an extra "manual mode" register.
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andreas Mohr <andi@xxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxx>
> Signed-off-by: Peter Feuerer <peter@xxxxxxxx>

Looks ok, I guess. I do worry a bit about the growing size of this
bios_tbl and how it contains lotsa repeated info - you might wanna think
of a slick scheme to slim it down one day, if you're bored.

Acked-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/