Re: Re: Re: [PATCH v5 2/2] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64

From: Ingo Molnar
Date: Thu Jul 17 2014 - 05:41:23 EST



* Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:

> (2014/07/16 22:28), Ingo Molnar wrote:
> >
> > * Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
> >
> >> (2014/07/15 16:16), Benjamin Herrenschmidt wrote:
> >>> On Tue, 2014-07-15 at 13:19 +1000, Michael Ellerman wrote:
> >>>
> >>>>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> >>>>> Reported-by: Tony Luck <tony.luck@xxxxxxxxx>
> >>>>> Tested-by: Tony Luck <tony.luck@xxxxxxxxx>
> >>>>> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >>>>
> >>>> Tested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >>>> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (for powerpc)
> >>>>
> >>>> Ben, can you take this in your tree?
> >>>
> >>> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> >>>
> >>> That looks more like generic material. Do we have a kprobes maintainer ?
> >>> Andrew, do you want to take this ?
> >>
> >> Yeah, I usually use Ingo's tip tree for kprobes maintenance.
> >> Ingo, could you pull this as urgent-for-linus patch?
> >
> > Mind resending it in a separate thread with all acks added, etc?
>
> OK, I'll resend that soon.
> BTW, I missed Suzuki's Signed-off-by in this version,
> I'd like to recover that since he made a big bugfix on this.

That kind of credit can be added as:

Fixed-by: Suzuki K. Poulose <suzuki@xxxxxxxxxx>

and by also adding a sentence to the log message (outside of the
version changelogs which get stripped ususally).

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/