Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

From: Saravana Kannan
Date: Wed Jul 16 2014 - 17:45:33 EST


On 07/16/2014 01:25 PM, Saravana Kannan wrote:
On 07/16/2014 01:24 AM, Viresh Kumar wrote:
On 16 July 2014 04:17, Saravana Kannan <skannan@xxxxxxxxxxxxxx> wrote:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c

@@ -1110,9 +1092,10 @@ static int __cpufreq_add_dev(struct device
*dev, struct subsys_interface *sif)

#ifdef CONFIG_SMP
/* check whether a different CPU already registered this
- * CPU because it is in the same boat. */
+ * CPU because it is one of the related CPUs. */
policy = cpufreq_cpu_get(cpu);
- if (unlikely(policy)) {
+ if (policy) {
+ cpufreq_change_policy_cpus(policy, cpu, true);

This is just a waste of time at boot as ... (see below)

Why? Please explain.


Nevermind. Figured what you meant. I just need to improve the "if" check.

-Saravana

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/