Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

From: Stanimir Varbanov
Date: Wed Jul 16 2014 - 08:07:30 EST


Hi,

<snip>
>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@xxxxxxxxx>
> CC: Josh Cartwright <joshc@xxxxxxxxxxxxxx>
> CC: Mark Brown <broonie@xxxxxxxxxx>
> ---
> This was found when I enabled support for Qualcomm QPNP PMICs and was
> compiling it. It selects REGMAP_SPMI and hence the crash.
>
> drivers/base/regmap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 4251570..1aa9d71 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -16,6 +16,7 @@ config REGMAP_SPI
> tristate
>
> config REGMAP_SPMI
> + select SPMI

NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and
multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example.

--
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/