Re: [PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

[Artem Bityutskiy]

On Mon, 2014-06-23 at 18:41 +0200, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
> 
> Cc: Artem Bityutskiy <dedekind1@xxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

In the commit message, please, try to not only tell _what_ you do,
but also _why_ you do this. And ideally, but not necessary for this
case, I think, how this was tested (e.g., compile-tested only).

Thanks! I'll apply this patch, and amend the commit message so that it
tells that kcalloc() makes better bob of the overflow checking.

-- 
Best Regards,
Artem Bityutskiy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/