Re: [patch] x86, perf: avoid spamming kernel log for bts buffer failure

[Peter Zijlstra]

On Mon, Jul 14, 2014 at 04:33:47PM -0700, David Rientjes wrote:
> On Mon, 30 Jun 2014, David Rientjes wrote:
> 
> > It's unnecessary to excessively spam the kernel log anytime the BTS buffer 
> > cannot be allocated, so make this allocation __GFP_NOWARN.
> > 
> > The user probably will want to at least find some artifact that the 
> > allocation has failed in the past, probably due to fragmentation because 
> > of its large size, when it's not allocated at bootstrap.  Thus, add a 
> > WARN_ONCE() so something is left behind for them to understand why perf 
> > commnads that require PEBS is not working properly.
> > 
> > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> 
> Peter, would you like to ack this?  Trying to get this merged in time for 
> the next merge window.

I've queued it; still don't like it though.

Attachment: pgpjOzZl98ey0.pgp
Description: PGP signature