Re: [PATCH 7/7] tracing: change filter_free_subsystem_*() to check ->subsystem rather then ->name

From: Oleg Nesterov
Date: Mon Jul 14 2014 - 15:25:46 EST


On 07/14, Steven Rostedt wrote:
>
> On Fri, 11 Jul 2014 21:06:55 +0200
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > @@ -846,13 +846,10 @@ static void filter_free_subsystem_preds(struct event_subsystem *system,
> > struct trace_array *tr)
> > {
> > struct ftrace_event_file *file;
> > - struct ftrace_event_call *call;
> >
> > list_for_each_entry(file, &tr->events, list) {
> > - call = file->event_call;
> > - if (strcmp(call->class->system, system->name) != 0)
> > + if (file->system->subsystem != system)
>
> This is only used on one place. What about just passing in dir instead
> of system and then do:

I swear, I too thought about this ;) OK, in v2.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/