Re: [PATCH 4/7] tracing: kill call_filter_disable()

[Steven Rostedt]

On Fri, 11 Jul 2014 21:06:47 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> It seems that the only purpose of call_filter_disable() is to
> make filter_disable() less clear and symmetrical, remove it.

But what will replace the purpose of making it less symmetrical and
clear?

This is the result of modifications over time.

-- Steve

> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---
>  kernel/trace/trace_events_filter.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index 1edec32..54a125c 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -774,17 +774,12 @@ static void __free_preds(struct event_filter *filter)
>  	filter->n_preds = 0;
>  }
>  
> -static void call_filter_disable(struct ftrace_event_call *call)
> -{
> -	call->flags &= ~TRACE_EVENT_FL_FILTERED;
> -}
> -
>  static void filter_disable(struct ftrace_event_file *file)
>  {
>  	struct ftrace_event_call *call = file->event_call;
>  
>  	if (call->flags & TRACE_EVENT_FL_USE_CALL_FILTER)
> -		call_filter_disable(call);
> +		call->flags &= ~TRACE_EVENT_FL_FILTERED;
>  	else
>  		file->flags &= ~FTRACE_EVENT_FL_FILTERED;
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/