Re: [Xen-devel] [PATCH v4] PCI back fixes for 3.17.

From: Konrad Rzeszutek Wilk
Date: Mon Jul 14 2014 - 13:45:57 EST


On Mon, Jul 14, 2014 at 07:43:04PM +0200, Sander Eikelenboom wrote:
>
> Monday, July 14, 2014, 7:37:53 PM, you wrote:
>
> >> >> Ad B)
> >> >>
> >> >> root@dom0:~# xl pci-list router
> >> >> Vdev Device
> >> >> 05.0 0000:00:1b.0
> >> >>
> >> >> root@dom0:~# xl pci-assignable-list
> >> >> 0000:02:00.0
> >> >>
> >> >> root@dom0:~# xl pci-detach router 00:1b.0
> >> >> dmesg shows:
> >> >> [ 199.742668] pciback 0000:00:1b.0: restoring config space at offset 0x10 (was 0x4, writing 0xf7d30004)
> >> >> [ 199.743527] pciback 0000:00:1b.0: restoring config space at offset 0xc (was 0x0, writing 0x10)
> >> >> [ 199.744321] pciback 0000:00:1b.0: restoring config space at offset 0x4 (was 0x100000, writing 0x100006)
> >> >> [ 199.757184] xen-pciback pci-1-0: xen_pcibk_xenbus_remove freeing pdev @ 0xffff8800589fce40
> >> >> [ 199.758139] xen-pciback pci-1-0: xen_pcibk_disconnect pdev @ 0xffff8800589fce40
> >> >> [ 199.862595] xen: xen_unregister_device_domain_owner
> >> >>
> >> >> xl dmesg shows:
> >> >> (XEN) [2014-07-14 16:28:29] memory_map:remove: dom1 gfn=f3070 mfn=f7d30 nr=4
> >> >> (XEN) [2014-07-14 16:28:29] io.c:322: d1: unbind: m_gsi=22 g_gsi=36 dev=00:00.5 intx=0
> >> >> (XEN) [2014-07-14 16:28:29] io.c:390: d1 unmap: m_irq=22 dev=00:00.5 intx=0
> >> >> (XEN) [2014-07-14 16:28:29] [VT-D]iommu.c:1579: d1:PCIe: unmap 0000:00:1b.0
> >> >> (XEN) [2014-07-14 16:28:29] [VT-D]iommu.c:1440: d0:PCIe: map 0000:00:1b.0
> >> >>
> >> >> root@dom0:~# xl pci-list router
> >> >> root@dom0:~# xl pci-assignable-list
> >> >> 0000:00:1b.0
> >> >> 0000:02:00.0
> >> >>
> >> >> root@dom0:~# xl pci-assignable-remove 00:1b.0
> >> >> dmesg shows:
> >> >> [ 318.827415] xen: xen_unregister_device_domain_owner
> >> >> [ 318.828771] xen: xen_unregister_device_domain_owner: ENODEV
> >> >> [ 318.930869] pciback 0000:00:1b.0: restoring config space at offset 0x10 (was 0x4, writing 0xf7d30004)
> >> >> [ 318.933435] pciback 0000:00:1b.0: restoring config space at offset 0xc (was 0x0, writing 0x10)
> >> >> [ 318.935877] pciback 0000:00:1b.0: restoring config space at offset 0x4 (was 0x100000, writing 0x100006)
> >> >>
> >> >> root@dom0:~# xl pci-list router
> >> >> root@dom0:~# xl pci-assignable-list
> >> >> 0000:02:00.0
> >> >>
> >> >>
> >>
> >> > And if you do:
> >>
> >> > # xl pci-detach router 02:00.0
> >>
>
> > Err, I meant
> > # xl pci-assignable-remove 02:00.0
>
> Ah ok .. so that is:
> remove a device from pciback that has never been assigned to any guest ..
>
> will also give that a go .. although that probably won't be a problem.

Right. So I think it all works as expected? That is if you have
two PCI devices assigned to a guest and want to re-use them you
have to do the 'pci-detach' twice and then follow that with
'pci-assignable-remove' twice as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/