Re: [PATCH char-misc-next v3 2/8] misc: mic: add a bus driver for virtual MIC devices

From: Greg Kroah-Hartman
Date: Fri Jul 11 2014 - 21:22:57 EST


On Fri, Jul 11, 2014 at 02:04:20PM -0700, Sudeep Dutt wrote:
> This MIC virtual bus driver takes the responsibility of creating all
> the virtual devices connected to the PCIe device on the host and the
> platform device on the card. The MIC bus hardware operations provide
> a way to abstract certain hardware details from the base physical devices.
> Examples of devices added on the MIC virtual bus include host DMA and card DMA.
> This abstraction enables using a common DMA driver on host and card.
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
> Reviewed-by: Nikhil Rao <nikhil.rao@xxxxxxxxx>
> Signed-off-by: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> Signed-off-by: Siva Yerramreddy <yshivakrishna@xxxxxxxxx>
> ---
> drivers/misc/mic/Kconfig | 17 ++++
> drivers/misc/mic/Makefile | 1 +
> drivers/misc/mic/bus/Makefile | 5 +
> drivers/misc/mic/bus/mic_bus.c | 218 +++++++++++++++++++++++++++++++++++++++++
> include/linux/mic_bus.h | 110 +++++++++++++++++++++
> 5 files changed, 351 insertions(+)
> create mode 100644 drivers/misc/mic/bus/Makefile
> create mode 100644 drivers/misc/mic/bus/mic_bus.c
> create mode 100644 include/linux/mic_bus.h

Looks good, but no addition to scripts/mod/file2alias.c to allow
autoloading of mic_bus drivers?

I'll take patches 1 and 2 here, as I need some acks from the DMA people
on patch 3.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/