Re: [PATCH net] r8152: fix r8152_csum_workaround function

From: David Miller
Date: Fri Jul 11 2014 - 17:52:39 EST


From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Fri, 11 Jul 2014 16:48:27 +0800

> The transport offset of the IPv4 packet should be fixed and wouldn't
> be out of the hw limitation, so the r8152_csum_workaround() should
> be used for IPv6 packets.
>
> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Applied and queued up for -stable, but this patch was harder to review
than it needed to be...

> - features &= ~(NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO);
> + features &= ~(NETIF_F_SG | NETIF_F_IPV6_CSUM | NETIF_F_TSO6);

because you changed the order of the flags unnecessarily.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/