Re: [PATCH 00/16] i2c: drop class based instantiaion for selected drivers

From: Wolfram Sang
Date: Thu Jul 10 2014 - 09:13:19 EST



> > + /* Warn that the adapter lost class based instantiation */
> > + if (adapter->class == I2C_CLASS_DEPRECATED) {
> > + dev_dbg(&adapter->dev,
> > + "This adapter dropped support for I2C classes and "
> > + "won't auto-detect %s devices anymore. If you need it, check "
> > + "'Documentation/i2c/instantiating-devices' for alternatives.\n",
> >
> It's usually a bad idea to split kernel messages across source lines

Yes, "usually". Not for this message, though, it's specific. The lines
would have been quite long.

> You could at least do the split at the sentence boundary.

OK, this would have been a compromise.

Attachment: signature.asc
Description: Digital signature