Re: [PATCH] drbd: fix regression 'out of mem, failed to invoke fence-peer helper'

From: Jens Axboe
Date: Thu Jul 10 2014 - 05:56:07 EST


On 2014-07-10 11:53, Philipp Reisner wrote:
Am Donnerstag, 10. Juli 2014, 11:07:22 schrieb Jens Axboe:
On 2014-07-09 21:18, Philipp Reisner wrote:
From: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>

Since linux kernel 3.13, kthread_run() internally uses
wait_for_completion_killable(). We sometimes may use kthread_run()
while we still have a signal pending, which we used to kick our threads
out of potentially blocking network functions, causing kthread_run() to
mistake that as a new fatal signal and fail.

Fix: flush_signals() before kthread_run().

Applied - should this have been marked stable, if it affects 3..13+ kernels?

Yes, you are right. It should go to the stable kernels since 3.13 as
well.

Alright, we'll have to notify Greg/stable when it goes in.

What is the correct way for me to mark it as stable when sending a patch?

You just add a:

Cc: stable@xxxxxxxxxx

where the signed-off-by is. If you know the versions it should be applied to, you can add that information as well. For this case, you would have done:

Cc: stable@xxxxxxxxxx # v3.13+

to get it into 3.13 stable and later.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/