Re: [PATCHv3 2/2] Add force_epp module option for parport_pc.

[Greg KH]

On Mon, Jul 07, 2014 at 11:01:51AM +0400, Matwey V. Kornilov wrote:
> >From cf37d0cc4d51da5c0b368e1f5ab05082c041d1e1 Mon Sep 17 00:00:00 2001
> From: "Matwey V. Kornilov" <matwey.kornilov@xxxxxxxxx>
> Date: Wed, 25 Jun 2014 01:08:45 +0400
> Subject: [PATCHv3 2/2] Add force_epp module option for parport_pc.
> 
> The detection of Intel EPP bug is known to produce much false positives.
> The new option is introduced to force enable EPP in spite of the test result.

module parameters are horrid, how is someone supposed to know to use
this?  Why can't we "fix" the detection logic?  You just now broke
systems that were working by forcing them to now set a module option
where previously they didn't, so I can't take these patches as-is,
sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/