RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Wednesday, July 9, 2014 1:40 AM
> To: KY Srinivasan
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> ohering@xxxxxxxx; jbottomley@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx;
> apw@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the
> values on the host
> 
> On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote:
> > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter.
> 
> Does it still?  The STORVSC_FC_MAX_TARGETS define suggests otherwise.

I will fix the comments and get rid of unnecessary comments.

> 
> > -	.cmd_per_lun =		1,
> > +	.cmd_per_lun =		255,
> 
> This looks like an unrelated change.

I will have a separate patch for this.
> 
> > +		/* max # of devices per target */
> > +		host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET;
> > +		/* max # of targets per channel */
> > +		host->max_id = STORVSC_FC_MAX_TARGETS;
> > +		/* max # of channels */
> > +		host->max_channel = STORVSC_FC_MAX_CHANNELS - 1;
> 
> I don't think these comments add any value..

I will get rid of the comments.

> 
> Also any reason you use off by one defines for max_channel, but not the
> others?

No particular reason; I will clean this up.


Thanks Christoph for the detailed comments. I will re-spin these after I address your comments.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/