Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

From: Michalis Pappas
Date: Wed Jul 09 2014 - 14:24:25 EST


On 07/09/2014 11:26 AM, Dan Carpenter wrote:
>> /* GetInformation mac address */
>> len = 0;
>> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device *dev)
>> hci->length = H2B(len);
>> gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
>>
>> - val = (1<<BIT_WIMAX) | (1<<BIT_MULTI_CS);
>> + val = (1 << T_CAPABILITY_WIMAX) | (1 << T_CAPABILITY_MULTI_CS);
>
> Double shifting here... It should just be:
>
> val = T_CAPABILITY_WIMAX | T_CAPABILITY_MULTI_CS;
>

Ooops! Thanks for spotting that, will submit a corrected patch.

M.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/