Re: [RFC PATCH 5/5] kernel/rcu/rcutorture.c:185 fix a sparse warning

[Paul E. McKenney]

On Wed, Jun 11, 2014 at 02:47:52PM -0700, josh@xxxxxxxxxxxxxxxx wrote:
> On Wed, Jun 11, 2014 at 04:39:43PM -0400, Pranith Kumar wrote:
> > fix the following sparse warning
> > 
> > kernel/rcu/rcutorture.c:185:1: warning: symbol 'boost_mutex' was not declared. Should it be static?
> > 
> > by marking boost_mutex as a static mutex
> > 
> > Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> 
> Please preserve the comment alignment (by deleting a tab).  With that
> fixed:
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Queued for 3.18.

But Pranith, next time Josh gives you a review comment, could you please
respond with the appropriate update?

							Thanx, Paul

> >  kernel/rcu/rcutorture.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> > index 7fa34f8..1cd4b2d 100644
> > --- a/kernel/rcu/rcutorture.c
> > +++ b/kernel/rcu/rcutorture.c
> > @@ -182,7 +182,7 @@ static u64 notrace rcu_trace_clock_local(void)
> >  #endif /* #else #ifdef CONFIG_RCU_TRACE */
> >  
> >  static unsigned long boost_starttime;	/* jiffies of next boost test start. */
> > -DEFINE_MUTEX(boost_mutex);		/* protect setting boost_starttime */
> > +static DEFINE_MUTEX(boost_mutex);		/* protect setting boost_starttime */
> >  					/*  and boost task create/destroy. */
> >  static atomic_t barrier_cbs_count;	/* Barrier callbacks registered. */
> >  static bool barrier_phase;		/* Test phase. */
> > -- 
> > 1.9.1
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/