Re: [PATCH v2 linux-next] tools: selftests - create a separate hotplug target for full range test

From: Andrew Morton
Date: Tue Jul 08 2014 - 18:31:20 EST


On Wed, 2 Jul 2014 09:51:38 -0600 Shuah Khan <shuah.kh@xxxxxxxxxxx> wrote:

> On some systems, hot-plug tests could hang forever waiting for cpu and
> memory to be ready to be offlined. A special hot-plug target is created
> to run full range of hot-plug tests. In default mode, hot-plug tests run
> in safe mode with a limited scope. In limited mode, cpu-hotplug test is
> run on a single cpu as opposed to all hotplug capable cpus, and memory
> hotplug test is run on 2% of hotplug capable memory instead of 10%. In
> addition to the above change, cpu-hotplug is chnged to change processor
> affinity to cpu 0 so it doesn't impact itself while the test runs.
>
> ...
>
> --- a/tools/testing/selftests/README.txt
> +++ b/tools/testing/selftests/README.txt
> @@ -4,8 +4,15 @@ The kernel contains a set of "self tests" under the tools/testing/selftests/
> directory. These are intended to be small unit tests to exercise individual
> code paths in the kernel.
>
> -Running the selftests
> -=====================
> +On some systems, hot-plug tests could hang forever waiting for cpu and
> +memory to be ready to be offlined. A special hot-plug target is created
> +to run full range of hot-plug tests. In default mode, hot-plug tests run
> +in safe mode with a limited scope. In limited mode, cpu-hotplug test is
> +run on a single cpu as opposed to all hotplug capable cpus, and memory
> +hotplug test is run on 2% of hotplug capable memory instead of 10%.
> +
> +Running the selftests (hotplug tests are run in limited mode)
> +=============================================================
>
> To build the tests:
>
> @@ -18,14 +25,26 @@ To run the tests:
>
> - note that some tests will require root privileges.
>
> -
> -To run only tests targetted for a single subsystem:
> +To run only tests targeted for a single subsystem: (including
> +hotplug targets in limited mode)
>
> $ make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests
>
> See the top-level tools/testing/selftests/Makefile for the list of all possible
> targets.
>
> +Running the full range hotplug selftests
> +========================================
> +
> +To build the tests:
> +
> + $ make -C tools/testing/selftests hotplug

Well. `make -C tools/testing/selftests' will build the hotplug tests,
won't it? We may as well *compile* everything by default..

>
> ...
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/