Re: [RFC 2/3] gpio: move sysfs support to its own file

From: Alexandre Courbot
Date: Tue Jul 08 2014 - 04:31:31 EST


On Tue, Jul 8, 2014 at 5:21 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Jul 1, 2014 at 7:45 AM, Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
>> sysfs support is currently entangled within the core GPIO support, while
>> it should relly just be a (privileged) user of the integer GPIO API.
>> This patch is a first step towards making the gpiolib code more readable
>> by splitting it into logical parts.
>>
>> Move all sysfs support to their own source file, and share static
>> members of gpiolib that need to be in the private gpiolib.h file. In
>> the future we will want to put some of them back into gpiolib.c, but this
>> first patch let us at least identify them.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>
> Patch applied. We really need to make refactorings like this
> so thanks a lot.

Excellent, glad you approve of this. I actually have some more coming
after that, since the current lack of organization stands in the way
of a proper multi-consumer GPIO implementation.

Thanks!
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/