Re: [PATCH 08/18] perf tools: Flush ordered events in case of allocation failure

[Jiri Olsa]

On Fri, Jun 27, 2014 at 05:07:52PM -0600, David Ahern wrote:
> On 6/18/14, 8:58 AM, Jiri Olsa wrote:
> >+	case OEQ_FLUSH__HALF:
> >+	{
> >+		struct ordered_event *first, *last;
> >+		struct list_head *head = &q->events;
> >+
> >+		first = list_entry(head->next, struct ordered_event, list);
> >+		last = q->last;
> >+
> >+		if (WARN_ONCE(!last || list_empty(head), "empty queue"))
> >+			return 0;
> 
> Maybe a comment that the WARN_ONCE can only happen if perf can't allocate an
> ordered event the first time through?

ok, will do..

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/