Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

From: Simon Glass
Date: Tue Jun 24 2014 - 11:53:32 EST


On 23 June 2014 15:20, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> In <https://lkml.org/lkml/2014/6/10/265> pointed out that the 10-bit
> flag in the cros_ec_tunnel was useless. It went into a 16-bit flags
> field but was defined at (1 << 16).
>
> Since we have no 10-bit i2c devices on the other side of the tunnel on
> any known devices this was never a problem. Until we do it makes
> sense to remove this code. On the EC side the code to handle this
> flag was removed in <https://chromium-review.googlesource.com/204162>.
>
> Reported-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>

Funny. We certainly don't use it.

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/