Re: [PATCH] mm:kswapd: clean up the kswapd

From: Mel Gorman
Date: Mon Jun 23 2014 - 07:19:22 EST


On Mon, Jun 23, 2014 at 01:14:54PM +0800, Chen Yucong wrote:
> According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from
> pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid
> unnecessary rebalance after an unsuccessful balancing), we can use a boolean
> variable for replace balanced_* variables, which makes the kswapd more clarify.
>
> Signed-off-by: Chen Yucong <slaoub@xxxxxxxxx>

I think this is just churning code for the sake of it. It's not any
easier to understand as a result of the modification and does not appear
to be a preparation for a follow-on patch that addresses a bug.

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/