Re: [patch V4 00/10] rtmutex: Code clarification and optimization

From: Ingo Molnar
Date: Sun Jun 22 2014 - 04:45:28 EST



* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> Hopefully the last iteration of this.
>
> I addressed all the review comments and added the following new ones:
>
> 1/n: plug unlock race.
>
> Patch was separately posted already in the safety of
> *mutex_unlock() thread.
>
> 2/n: Document and simplify the trylock path
>
> 3/n: Document and simplify try_to_take_rtmutex()

JFYI, the Blackfin cross-build fails with:

/home/mingo/tip/kernel/locking/rtmutex.c: In function 'rt_mutex_adjust_prio_chain':
/home/mingo/tip/kernel/locking/rtmutex.c:739: error: unable to find a register to spill in class 'CCREGS'
/home/mingo/tip/kernel/locking/rtmutex.c:739: error: this is the insn:
(insn 82 75 107 2 /home/mingo/tip/kernel/locking/rtmutex.c:487 (set
(reg:BI 186)
(eq:BI (reg/v/f:SI 9 P1 [orig:85 top_waiter ] [85])
(const_int 0 [0x0]))) 111 {compare_eq} (nil))
/home/mingo/tip/kernel/locking/rtmutex.c:739: confused by earlier errors, bailing out

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/