Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path

From: Borislav Petkov
Date: Sat Jun 21 2014 - 06:09:11 EST


On Fri, Jun 20, 2014 at 10:04:37PM -0400, Boris Ostrovsky wrote:
> I'll try it later but this doesn't look sufficient to me: we might not
> reach this point if subsys_system_register() or zalloc_cpumask_var()
> fail.

If those fail, I'd say we have a much bigger problem than undeleted
timers.

> We could register the notifier as the first thing in this routine
> (probably after mce_available() succeeds).

I guess...

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/