Re: [PATCH] mm: slub: SLUB_DEBUG=n: use the same alloc/free hooks as for SLUB_DEBUG=y

[Christoph Lameter]

On Thu, 19 Jun 2014, Andrew Morton wrote:

> (Is that a nack?)

Not sure.

> The intent seems to have been implemented strangely.  Perhaps it would
> be clearer and more conventional to express all this using Kconfig
> logic.

Well it really does not work right since SLUB_DEBUG=y is the default
config and this behavior would be a bit surprising.

> Anyway, if we plan to leave the code as-is then can we please get a
> comment in there so the next person is not similarly confused?

Ok. Lets apply the patch.

Gosh. I think we need some way to figure out if code is being added to the
critical paths. I had no idea about that latest issue where might_sleep
suddenly became a call to cond_resched() until I saw the bug report.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/