Re: [PATCH 2/2 v3] staging: comedi: ni_daq_700: add AI range and input mode switching

From: Ian Abbott
Date: Fri Jun 20 2014 - 08:05:46 EST


On 2014-06-20 12:53, Ian Abbott wrote:
From: Fred Brooks <frederick.brooks@xxxxxxxxxxxxx>

Add support for switching the input range and the single-ended/
differential input mode for the AI subdevice. We needed to clear the
FIFO of data before the conversion to handle card mode switching
glitches.

[ Minor whitespace fixes and driver comment reformatting. - Ian ]

Signed-off-by: Fred Brooks <frederick.brooks@xxxxxxxxxxxxx>
Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
---
v2: Set authorship to Fred Brooks and updated patch description as
suggested by Dan Carpenter.
v3: Rebased to fix merge conflict with "staging: comedi: ni_daq_700: add
mux settling delay" patch. The channel number ('chan') doesn't need
ANDing with 0xf as it will be less than 16.

I forgot to add:

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

from his reply to the v2 patch.

I'll strip out the the module version information in a subsequent patch. I don't think the minor code formatting niggles matter enough to worry about.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/