Re: [PATCH] mm: percpu: micro-optimize round-to-even

From: Christoph Lameter
Date: Thu Jun 19 2014 - 10:59:26 EST


On Thu, 19 Jun 2014, Tejun Heo wrote:

> Indeed, a patch?

Subject: percpu: Use ALIGN macro instead of hand coding alignment calculation

Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

Index: linux/mm/percpu.c
===================================================================
--- linux.orig/mm/percpu.c 2014-06-04 13:43:12.541466633 -0500
+++ linux/mm/percpu.c 2014-06-19 09:56:10.458023912 -0500
@@ -720,8 +720,7 @@ static void __percpu *pcpu_alloc(size_t
if (unlikely(align < 2))
align = 2;

- if (unlikely(size & 1))
- size++;
+ size = ALIGN(size, 2);

if (unlikely(!size || size > PCPU_MIN_UNIT_SIZE || align > PAGE_SIZE)) {
WARN(true, "illegal size (%zu) or align (%zu) for "
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/